Add lint-graphql job #55
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccamel
force-pushed
the
ci/graphql-inspector
branch
4 times, most recently
from
245e328 to
aa792ef
Compare
ccamel
force-pushed
the
ci/graphql-inspector
branch
from
aa792ef to
6bd251a
Compare
amimart
approved these changes
Sep 4, 2023
bdeneux
approved these changes
Sep 4, 2023
ccamel
force-pushed
the
ci/graphql-inspector
branch
from
6bd251a to
71358a5
Compare
ccamel
force-pushed
the
ci/graphql-inspector
branch
from
71358a5 to
f9878d8
Compare
|
No longer works because the evaluated schema is incomplete (e.g. the |
jeremylgn
approved these changes
Sep 4, 2023
|
AFIK, it doesn't seem possible to extract the complete GraphQL schema directly from the subql cli. Then, the safest approach would be to do the following: as part of the CI workflow execution, start two instances of SubQL, one on the main branch and another on the PR branch. Then use the actions/graphql-inspector to perform the diff between the two, resolving their respective GraphQL endpoints. A bit cumbersome, but safer, I guess. FYI @amimart |
ccamel
force-pushed
the
main
branch
5 times, most recently
from
d6b456c to
9280ca2
Compare
ccamel
force-pushed
the
main
branch
2 times, most recently
from
c55941b to
02b1c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #6 by integrating the actions/graphql-inspector GitHub action into the CI.
To be tested in more depth with future PRs that amend the schema.