Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] Bump UMF to early 0.11 version, from main #2596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[common] Bump UMF to early 0.11 version, from main #2596

wants to merge 1 commit into from

Conversation

lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Jan 22, 2025 •
edited
Loading

intel/llvm testing: intel/llvm#16749

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner January 22, 2025 10:13
@github-actions github-actions bot added the common Changes or additions to common utilities label Jan 22, 2025
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft January 22, 2025 13:42
@lukaszstolarczuk
Copy link
Contributor Author

changed to draft as I should probably also include macos fix already oneapi-src/unified-memory-framework#1052

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review January 23, 2025 11:36
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jan 23, 2025
Draft
@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft January 23, 2025 14:27
@lukaszstolarczuk
Copy link
Contributor Author

I'm afraid there's an issue with hwloc, probably failing because of UMF change - investigating...

@lukaszstolarczuk
Copy link
Contributor Author

hwloc issue introduced on UMF's main is being reverted, waiting for this PR: oneapi-src/unified-memory-framework#1056

@lukaszstolarczuk lukaszstolarczuk force-pushed the bump-umf-0.11 branch 2 times, most recently from b20d26d to a5b080d Compare January 24, 2025 16:29
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jan 24, 2025
Merged
@lukaszstolarczuk
[common] Bump UMF to early 0.11 version, from main
d193046 
It includes i.a. MacOS fix for compiler.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review January 27, 2025 12:17
@lukaszstolarczuk
Copy link
Contributor Author

UMF required fixes are included, intel/llvm testing is passing now, so I guess it's ready for review.

@bratpiorka
Copy link
Contributor

@lukaszstolarczuk should we wait for oneapi-src/unified-memory-framework#1063?

@lukaszstolarczuk
Copy link
Contributor Author

@lukaszstolarczuk should we wait for oneapi-src/unified-memory-framework#1063?

TBH, I don't think this one is neccessary for this update. This is not the final release v0.11.0, more UMF bumps in UR incoming 😉

@lukaszstolarczuk
Copy link
Contributor Author

@kbenzie, do you think we could merge this one soon?

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Jan 30, 2025
@kbenzie
Copy link
Contributor

kbenzie commented Jan 30, 2025

@kbenzie, do you think we could merge this one soon?

There are issues with Windows runners on intel/llvm so we'll need to wait until those are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswiecicki kswiecicki kswiecicki approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
common Changes or additions to common utilities ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukaszstolarczuk @bratpiorka @kbenzie @pbalcer @kswiecicki