-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Policy File #757
Initial Policy File #757
Conversation
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
I also updated our deps to the latest version in hopes they have added their privacy files |
In openHAB iOS Firebase is most critical SDK for privacy policy. We should upgrade it to 10.x to take advantage of included privacy manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, user defaults should suffice from what I've seen with other apps 👍
But yes, as @timbms said, Firbase needs to be updated to the latest version. |
Thanks! |
Question, i see we have |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
SPM configuration was restricting the major version to < 9.0.0. Therefore it could not go beyond the latest 8.x version |
As @timbms said you need to adjust the minimum major version. I'd suggest to install something like https://github.com/kiliankoe/swift-outdated, to make it easier to check if updates are available. |
Afair there was a bug that broke builds and we had to pin the version. Probably just forgot to unpin when it got fixed. Personally I'd like to switch to xcodegen. |
I archived a project and got this output in the generated privacy report openHAB-PrivacyReport 2024-05-26 18-20-13.pdf.
|
I got rid of all errors on the privacy report. @digitaldan as you already merged you can paste the plist below into PrivacyInfo.xcprivacy file
|
No description provided.