Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Policy File #757

Merged
merged 4 commits into from
May 26, 2024
Merged

Conversation

digitaldan
Copy link
Contributor

No description provided.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan mentioned this pull request May 25, 2024
15 tasks
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

I also updated our deps to the latest version in hopes they have added their privacy files

@digitaldan digitaldan requested review from weakfl and timbms May 25, 2024 19:16
@timbms
Copy link
Contributor

timbms commented May 26, 2024

In openHAB iOS Firebase is most critical SDK for privacy policy. We should upgrade it to 10.x to take advantage of included privacy manifests.

Copy link
Contributor

@weakfl weakfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, user defaults should suffice from what I've seen with other apps 👍

@weakfl
Copy link
Contributor

weakfl commented May 26, 2024

But yes, as @timbms said, Firbase needs to be updated to the latest version.

@digitaldan
Copy link
Contributor Author

Thanks!
Funny, i used xcode to upgrade all packages and assumed it got Firebase, but Xcode thinks 8.15 is the latest stable and did not upgrade it at all! Looking around the interwebs, it seems others have this issue as well with firebase and xcode, I'll fix that one here shortly and merge.

@digitaldan
Copy link
Contributor Author

Question, i see we have AlamoFire pinned at version 5.4.4 , i removed this restriction so xcode upgraded it to 5.9.1 and everything seems to work, anyone remember why its pinned ?

@timbms
Copy link
Contributor

timbms commented May 26, 2024

Thanks! Funny, i used xcode to upgrade all packages and assumed it got Firebase, but Xcode thinks 8.15 is the latest stable and did not upgrade it at all! Looking around the interwebs, it seems others have this issue as well with firebase and xcode, I'll fix that one here shortly and merge.

SPM configuration was restricting the major version to < 9.0.0. Therefore it could not go beyond the latest 8.x version

@digitaldan digitaldan merged commit 46d711d into openhab:develop May 26, 2024
2 checks passed
@weakfl
Copy link
Contributor

weakfl commented May 26, 2024

As @timbms said you need to adjust the minimum major version.

I'd suggest to install something like https://github.com/kiliankoe/swift-outdated, to make it easier to check if updates are available.

@weakfl
Copy link
Contributor

weakfl commented May 26, 2024

Question, i see we have AlamoFire pinned at version 5.4.4

Afair there was a bug that broke builds and we had to pin the version. Probably just forgot to unpin when it got fixed.

Personally I'd like to switch to xcodegen.

@timbms
Copy link
Contributor

timbms commented May 26, 2024

I archived a project and got this output in the generated privacy report openHAB-PrivacyReport 2024-05-26 18-20-13.pdf.
We probably need to fix this error before we can upload the build:

Missing an expected key: 'NSPrivacyCollectedDataTypes'

@timbms
Copy link
Contributor

timbms commented May 26, 2024

I got rid of all errors on the privacy report. @digitaldan as you already merged you can paste the plist below into PrivacyInfo.xcprivacy file

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyAccessedAPITypes</key>
	<array>
		<dict>
			<key>NSPrivacyAccessedAPIType</key>
			<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
			<key>NSPrivacyAccessedAPITypeReasons</key>
			<array>
				<string>CA92.1</string>
			</array>
		</dict>
	</array>
	<key>NSPrivacyCollectedDataTypes</key>
	<array>
		<dict>
			<key>NSPrivacyCollectedDataTypeTracking</key>
			<false/>
			<key>NSPrivacyCollectedDataType</key>
			<string>NSPrivacyCollectedDataTypeCrashData</string>
			<key>NSPrivacyCollectedDataTypeLinked</key>
			<false/>
			<key>NSPrivacyCollectedDataTypePurposes</key>
			<array>
				<string>
                        NSPrivacyCollectedDataTypePurposeAppFunctionality
                    </string>
			</array>
		</dict>
		<dict>
			<key>NSPrivacyCollectedDataTypeTracking</key>
			<false/>
			<key>NSPrivacyCollectedDataType</key>
			<string>NSPrivacyCollectedDataTypeOtherDiagnosticData</string>
			<key>NSPrivacyCollectedDataTypeLinked</key>
			<false/>
			<key>NSPrivacyCollectedDataTypePurposes</key>
			<array>
				<string>
                        NSPrivacyCollectedDataTypePurposeAppFunctionality
                    </string>
			</array>
		</dict>
	</array>
</dict>
</plist>

@digitaldan
Copy link
Contributor Author

Thanks @timbms ! See #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants