Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vclient.c #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update vclient.c #120

wants to merge 1 commit into from

Conversation

ergorion
Copy link

small fix to allow the output of system time in a csv file.

small fix to allow the output of system time in a csv file.
@hmueller01
Copy link
Collaborator

hmueller01 commented Feb 14, 2023

I think it's not good to have getSystemTime hard coded in vclient.c. It's just a tag in vito.xml, e.g.:

    <command name="getSystemTime" protocmd="getaddr">
      <addr>088E</addr>
      <len>8</len>
      <unit>TI</unit>
      <description>Ermittle Systemzeit</description>
      <device ID="2053"/>
    </command>

But I don't have a better idea right now ...

@ergorion
Copy link
Author

You are right, it's hard coded. But it helps people to simply output the system date... From what I saw on the web, I was not the only one with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants