Implement Enumerator#produce #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LillianZ
force-pushed
the
EnumeratorProduce
branch
from
e3bafe6 to
f84408b
Compare
LillianZ
force-pushed
the
EnumeratorProduce
branch
from
f84408b to
a8eb4f0
Compare
LillianZ
force-pushed
the
EnumeratorProduce
branch
from
a8eb4f0 to
47db835
Compare
eregon
approved these changes
Nov 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Enumerator#produce for Ruby 2.7 compatibility #2004
The reference implementation at https://github.com/zverok/enumerator_generate for the feature suggestion in https://bugs.ruby-lang.org/issues/14781 was in Ruby, so this is that (with default initial value set to nil and size set to Infinity).
The author agreed to make the code available under the same licence as Ruby(https://bugs.ruby-lang.org/issues/14781#note-27).
The major difference is the MRI has a Producer subclass, but MRI's Enumerator::Producer.new takes 0 arguments, so it should be fine that we don't have that method.
Shopify#1 (?)