Add IO#set_encoding_by_bom method #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawandubey
commented
Jun 4, 2021
|
Hello Pawan Dubey, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address pawan -(dot)- dubey -(at)- shopify -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
chrisseaton
reviewed
Jun 4, 2021
eregon
reviewed
Jun 6, 2021
|
Pawan Dubey has signed the Oracle Contributor Agreement (based on email address pawan -(dot)- dubey -(at)- shopify -(dot)- com) so can contribute to this repository. |
pawandubey
force-pushed
the
io-set-encoding-by-bom
branch
from
e3cd6f2 to
b41bbcd
Compare
eregon
reviewed
Jun 7, 2021
Method was introduced in MRI in 2.7.0 in e717d6faa
pawandubey
force-pushed
the
io-set-encoding-by-bom
branch
from
b41bbcd to
365dfa6
Compare
graalvmbot
pushed a commit
that referenced
this pull request
Jun 8, 2021
PullRequest: truffleruby/2704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2004
Adds the
IO#set_encoding_by_bommethod. Method was introduced in MRI in 2.7.0 in ruby/ruby@e717d6faa.I've basically reproduced the implementation from the MRI commit linked above.