Fill SnapshotId in Disk structure - v0.X #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mdr
force-pushed
the
idempotency_snapshot_create
branch
from
794e61b to
10a718b
Compare
outscale-mdr
changed the title
Signed-off-by: Maxime Dufour <maxime.dufour@outscale.com>
outscale-mdr
force-pushed
the
idempotency_snapshot_create
branch
from
10a718b to
6910f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
This PR is to fix a bug o idempotency in
CreateVolumecall. Indeed, if another call is submited with the same parameter with snapshotId, the second call with failed with an error.What is this PR about? / Why do we need it?
All calls must be idempotent therefore this is necessary in order not to be stuck
What testing is done?
Test of the cloud Call have been added to detect any future regression on this.