Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y issues in "Server Activities" tab #11690

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Jun 10, 2024

The notifications are now shown in a group box named "Notifications", and the server activities are shown in another group box named "Server Activities". The labels have been removed, as the group box titles take their role.

The tab order has also been fixed.

The notifications are now shown in a group box named "Notifications",
and the server activities are shown in another group box named "Server
Activities". The labels have been removed, as the group box titles take
their role.
@erikjv erikjv requested a review from TheOneRing June 10, 2024 11:22
@erikjv erikjv self-assigned this Jun 10, 2024
@erikjv
Copy link
Collaborator Author

erikjv commented Jun 10, 2024

Server activities:

Screenshot 2024-06-10 at 13 24 05

Notifications:

Screenshot 2024-06-10 at 13 28 11

@erikjv erikjv linked an issue Jun 10, 2024 that may be closed by this pull request
@erikjv erikjv merged commit b5ad3ee into master Jun 11, 2024
7 checks passed
@erikjv erikjv deleted the work/server-activities-a11y branch June 11, 2024 14:47
@saw-jan
Copy link
Member

saw-jan commented Sep 18, 2024

Tested on ownCloud 6.0.0.14688-daily20240918 [967f29]

Screenshot from 2024-09-18 18-35-58

  • Grouped notifications and activities ✔️
  • Tab flow might not be correct: ❓
    Server Activity -> Notifications -> Server Activities: Filter -> Server Activities: table -> Notifications: [Dismiss|Accept|Decline]

@TheOneRing
Copy link
Contributor

Not correct but better than before, we plan to rework notifications in the next release

@saw-jan
Copy link
Member

saw-jan commented Sep 20, 2024

Opened a new issue: #11890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server activity tab: tab order does not follow visual arrangement
3 participants