Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loot): ignore intersection if rarity threshold not set #647

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix(loot): ignore intersection if rarity threshold not set #647

merged 2 commits into from
Jan 30, 2025

Conversation

iProdigy
Copy link
Member

Rarity threshold set to zero with value-rarity intersection required would previously prevent any notifications; closes #646

@iProdigy iProdigy marked this pull request as ready for review January 30, 2025 04:41
@iProdigy iProdigy requested review from pajlada and Felanbird January 30, 2025 04:41
Felanbird
Felanbird approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test

@iProdigy iProdigy merged commit d0bbc17 into master Jan 30, 2025
5 checks passed
@iProdigy iProdigy deleted the fix/loot-intersection-unset-rarity branch January 30, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LOOT] Muspah doesn't trigger Loot notification in certain config
3 participants
@iProdigy @pajlada @Felanbird