Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Info panel not configurable via new ParseDashboard() when running as express middleware #2639

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: Info panel not configurable via new ParseDashboard() when running as express middleware #2639

merged 2 commits into from
Jan 29, 2025

Conversation

vardhan0604
Copy link
Contributor

@vardhan0604 vardhan0604 commented Jan 28, 2025 •
edited
Loading

New Pull Request Checklist

Issue Description

Closes: #2638

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jan 28, 2025 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@uffizzi-cloud Uffizzi Cloud
Copy link

uffizzi-cloud bot commented Jan 28, 2025

Uffizzi Ephemeral Environment deployment-60366

⌚ Updated Jan 28, 2025, 17:21 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2639

📄 View Application Logs etc.

What is Uffizzi? Learn more

@vardhan0604
Copy link
Contributor Author

Hey @mtrezza, could you please review this PR? Thanks!

@mtrezza
Copy link
Member

mtrezza commented Jan 28, 2025

@vardhan0604 is this really all or are there commits missing in this PR?

@vardhan0604
Copy link
Contributor Author

vardhan0604 commented Jan 28, 2025 •
edited
Loading

Yeah@mtrezza, I tried it, and this fixed the issue. Can you review it locally??

@mtrezza
Copy link
Member

mtrezza commented Jan 28, 2025

I'll review, but could you explain what effect this change has? What's the purpose of this line, are there maybe any other side effects?

@vardhan0604
Copy link
Contributor Author

I'll review, but could you explain what effect this change has? What's the purpose of this line, are there maybe any other side effects?

This change was originally introduced in PR #2584. The setBasePath() function updates the base path, but in this case, it wasn’t actually necessary. While it worked fine when a config file was present, it caused issues when used as an Express middleware. Removing it prevents unintended base path changes in that scenario.

Let me know if you need further clarification!

@mtrezza mtrezza changed the title fix: Info panel not configurable via options fix: Info panel not configurable via options when running as express middleware Jan 29, 2025
@mtrezza mtrezza changed the title fix: Info panel not configurable via options when running as express middleware fix: Info panel not configurable via new ParseDashboard() when running as express middleware Jan 29, 2025
@mtrezza mtrezza merged commit a9b8cd4 into parse-community:alpha Jan 29, 2025
10 checks passed
parseplatformorg pushed a commit that referenced this pull request Jan 29, 2025
@semantic-release-bot
chore(release): 6.0.0-alpha.22 [skip ci]
e06e577 
# [6.0.0-alpha.22](6.0.0-alpha.21...6.0.0-alpha.22) (2025-01-29)

### Bug Fixes

* Info panel not configurable via `new ParseDashboard()` when running as express middleware ([#2639](#2639)) ([a9b8cd4](a9b8cd4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.22

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Info panel not configurable via options
3 participants
@vardhan0604 @mtrezza @parseplatformorg