Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (3ds): remove LSAT and utilize sdk token #2463

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mchoun
Copy link
Contributor

@mchoun mchoun commented Jan 21, 2025

Description

This PR is to remove the usage of the Low Scoped Access Token in the eligibility request to the v2/payments/payment API. Instead, the merchant will need to pass the SDK Client token in the data-sdk-client-token attribute for the PayPal script tag.

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

JIRA Ticket - DTPPCPSDK-2891

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@mchoun mchoun changed the title remove lsat and utilize sdk token feat (3ds): remove LSAT and utilize sdk token Jan 21, 2025
@mchoun mchoun force-pushed the feature/2891-lsat-removal branch from c01927c to 32b6386 Compare January 22, 2025 22:52
@mchoun mchoun marked this pull request as ready for review January 22, 2025 23:17
@mchoun mchoun requested a review from a team as a code owner January 22, 2025 23:17
Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean

Copy link
Contributor

@ravishekhar ravishekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls merge when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants