Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MR1K1 Bend State Mover to 1 Dimension #132

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Nov 20, 2024

Description

  • changed mr1k1 bend 2d state mover implementation to 1d in PRG_MR1K1_BEND
  • I left 2d implementation commented so it can be re-implementated when the motor gets replaced.

Motivation and Context

  • MR1K1 Xdwn stream motor had a catastrophic failure and needs replacement; currently unlpugged along with Xup.

How Has This Been Tested?

  • deployed and tested state mover motions from OUT to B4C and back OUT.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-6792

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@nrwslac nrwslac changed the title ENH: change 2d state mover to 1d for MR1K1 Change MR1K1 Bend State Mover to 1 Dimension Nov 20, 2024
@nrwslac nrwslac marked this pull request as ready for review November 20, 2024 18:27
Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the state positioner has been changed to 1D correctly.
I was wondering, does the PMPS database need to be updated for this at all? Or was the PMPs only every based on the Y position? If so, I don't think we should even have the X motion be apart of a PMPS state mover. We should actually put the X motion on a 1D motion state mover and keep the Y axis on a 1D PMPS motion state mover.

@nrwslac nrwslac merged commit f983511 into pcdshub:master Nov 20, 2024
9 checks passed
@nrwslac
Copy link
Contributor Author

nrwslac commented Nov 20, 2024

I believe the state positioner has been changed to 1D correctly. I was wondering, does the PMPS database need to be updated for this at all? Or was the PMPs only every based on the Y position? If so, I don't think we should even have the X motion be apart of a PMPS state mover. We should actually put the X motion on a 1D motion state mover and keep the Y axis on a 1D PMPS motion state mover.

This worth thinking about, but X axis determines coating selection which requires PMPS. However, they rarely if ever move to the second coating as we found out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants