#31: Make failure text optional (#32)

- Made failure text optional - removed unnecessary variable, inlined return - Updated packages (npm audit fix)
phoenix-actions · Apr 4, 2023 · 8af4e4d · 8af4e4d
1 parent f0df84c
commit 8af4e4d
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 62 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/parsers/java-junit/java-junit-parser.ts b/src/parsers/java-junit/java-junit-parser.ts
@@ -66,8 +66,7 @@ export class JavaJunitParser implements TestParser {
         : junit.testsuites.testsuite.map(ts => {
             const name = ts.$.name.trim()
             const time = parseFloat(ts.$.time) * 1000
-            const sr = new TestSuiteResult(name, this.getGroups(ts), time)
-            return sr
+            return new TestSuiteResult(name, this.getGroups(ts), time)
           })
 
     const seconds = parseFloat(junit.testsuites.$?.time)
@@ -124,7 +123,7 @@ export class JavaJunitParser implements TestParser {
     }
 
     const failure = failures[0]
-    const details = typeof failure === 'object' ? failure._ : failure
+    const details = typeof failure === 'object' ? failure._  ?? "" : failure
     let filePath
     let line
 

diff --git a/src/parsers/java-junit/java-junit-types.ts b/src/parsers/java-junit/java-junit-types.ts
@@ -39,7 +39,7 @@ export interface TestCase {
 }
 
 export interface Failure {
-  _: string
+  _?: string
   type: string
   message: string
 }