Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error fixes on Node Page #127

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Error fixes on Node Page #127

merged 1 commit into from
Jan 16, 2025

Conversation

manas-qm
Copy link
Collaborator

No description provided.

@manas-qm manas-qm self-assigned this Jan 16, 2025
Copy link
Contributor

@nulinspiratie nulinspiratie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But a few minor modification requests to have it match Figma:

  • If an error occurs, it should not also show the "state updates" title
  • There is too much vertical space between the components
  • There is a bit too much horizontal margins, especially on the right-hand side
  • The message + traceback should not have horizontal indentation
  • The "Error occurred" and "Error traceback" should have a darker grey colour

Have a look at the figma image, and try to match it

Screenshot 2025-01-16 at 09 33 53

Small-screen version:
As can be seen, the error message + traceback has too much horizontal margins
Screenshot 2025-01-16 at 10 46 48

@nulinspiratie nulinspiratie merged commit 2499014 into main Jan 16, 2025
2 of 3 checks passed
@nulinspiratie nulinspiratie deleted the fix/node-page-fixes branch January 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants