-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code to copy instance methods from original original class defini… #81
base: main
Are you sure you want to change the base?
Conversation
…tion to Pydantic model.
@maxim-v4s I can't run the formatting-checking code locally, but clearly see that what I wrote didn't make it happy. In addition to reviewing, could you please reformat and see that tests pass? Thanks |
@deanpoulos just to confirm, this should work even if the custom class is defined in a script, and it should work both when you run it locally and through the FE? |
@maxim-v4s some context for this PR: @deanpoulos want to add methods to a |
@nulinspiratie @deanpoulos |
@deanpoulos it seems that this PR introduces some breaking changes, specifically in situations where the original NodeParameters have required parameters (without a default value). In that case, loading a serialized object can raise an error. |
@nulinspiratie I'm glad you picked up on some breaking changes. Since I don't know the ins-and-outs of QUAlibrate, and how difficult an alternative implementation would be, can I leave this to you to prioritize? Even if it goes to the bottom of the list, it's OK. |
Copy all callable attributes from the
parameters
instance to the Pydantic model that eventually replaces theparameters
instance asQualibrationNode.parameters