-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge ansible role octavia_preconf as per jira OSPC-189 #653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in lab and worked as expected.
Hello, I've removed the tests directory from the ansible role to prevent the CI jobs from trying to run the role and modified the shell scripts accordingly |
failing due to ansible-lint and trailing whitespaces. |
ansible/roles/octavia_preconf/templates/octavia_amphora_provider.yaml.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Just a couple nits on the readme and a few changes to make the linter happy. I would also like to see the practical application of this role documented within our octavia operations guide.
Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
…able names in double quotes in shell scripts Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
this PR is being raised for jira [1] to merge the ansible role to automate the required pre-requisites for enabling the amphora provider for octavia. The ansible role currently has tasks for:
the role can run from the bastion node and currently has a required to use a shell script because the openstack.cloud.port module doesn't include "--host" argument which is required for creating health-manager ports. It should also be note that currently the ansible role creates health-manager ports for nodes labelled as "openstack-control-plane=enabled"
I will be raising a separate PR for the playbook to run this ansible role and a document
[1] https://rackspace.atlassian.net/browse/OSPC-189