Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge ansible role octavia_preconf as per jira OSPC-189 #653

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

puni4220
Copy link
Contributor

this PR is being raised for jira [1] to merge the ansible role to automate the required pre-requisites for enabling the amphora provider for octavia. The ansible role currently has tasks for:

  1. creating the lb-mgmt-net and lb-mgmt-subnet
  2. creating the required security groups
  3. creating the ssh keypair for logging into amphora
  4. creating the required certificates for the amphora provider
  5. creating the required helm amphora values file to enable the amphora provider
  6. creating the required flavor for the amphora instances
  7. modifying the quotas for the admin tenant to accomodate amphorae
  8. creating the health-manager ports

the role can run from the bastion node and currently has a required to use a shell script because the openstack.cloud.port module doesn't include "--host" argument which is required for creating health-manager ports. It should also be note that currently the ansible role creates health-manager ports for nodes labelled as "openstack-control-plane=enabled"

I will be raising a separate PR for the playbook to run this ansible role and a document

[1] https://rackspace.atlassian.net/browse/OSPC-189

Copy link
Contributor

@japerezjr japerezjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in lab and worked as expected.

@puni4220
Copy link
Contributor Author

Hello, I've removed the tests directory from the ansible role to prevent the CI jobs from trying to run the role and modified the shell scripts accordingly

@rackerchris
Copy link
Contributor

failing due to ansible-lint and trailing whitespaces.

Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Just a couple nits on the readme and a few changes to make the linter happy. I would also like to see the practical application of this role documented within our octavia operations guide.

Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
…able names in double quotes in shell scripts

Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
Signed-off-by: puni4220 <punitshankar.kundal@rackspace.com>
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@rackerchris rackerchris merged commit ed56490 into rackerlabs:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants