[TEST] Test cuSpatial with artifacts from rapidsai/rmm#1095 #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
feature request
isVoid
reviewed
Nov 13, 2023
| @@ -14,7 +14,7 @@ def _test_hausdorff_from_list_of_spaces(spaces): | |||
| def test_empty(): | |||
| actual = _test_hausdorff_from_list_of_spaces([]) | |||
|
|
|||
| expected = cudf.DataFrame([]) | |||
| expected = cudf.DataFrame([], columns=cudf.Index([])) | |||
There was a problem hiding this comment.
Likely an upstream cuDF change made the empty Dataframe uses a RangeIndex as the column names, instead of cudf.Index. Since semantically both represent empty column names, I simply change the gold result here to let tests pass.
There was a problem hiding this comment.
OK thanks. Sounds like once everything is passing we will need to update this PR to remove the CI changes and get this fix merged in?
There was a problem hiding this comment.
I think that's right, otherwise we might have to handle this at release time.
…patial into test/cuspatial-test-rmm-1095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cuSpatial with changes from rapidsai/rmm#1095
Description
Checklist