-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Refined the paginator #135
Open
ckersey2
wants to merge
4
commits into
raycharius:main
Choose a base branch
from
ckersey2:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckersey2
changed the title
Main
Hide Previous and Next buttons when they are not needed in the Paginator
Jul 19, 2024
ckersey2
changed the title
Hide Previous and Next buttons when they are not needed in the Paginator
🚜Hide Previous and Next buttons when they are not needed in the Paginator
Jul 19, 2024
ckersey2
changed the title
🚜Hide Previous and Next buttons when they are not needed in the Paginator
🚜Hide previous and next buttons when they are not needed in the paginator
Jul 19, 2024
ckersey2
commented
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small tweek.
ckersey2
changed the title
🚜Hide previous and next buttons when they are not needed in the paginator
✨ Add new feature for pagination
Jul 20, 2024
If we are on the first page of the data, the "Previous" button is not shown. If we are on the last page of the data, the "Next" button is not shown. I've updated the following tests: - easy-paginator.spec.ts - paginator.spec.ts All tests pass.
Clearing linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💄 Refined the paginator
Updated the pagination actions buttons
If we are on the first page of the data, the "Previous" button is not shown.
If we are on the last page of the data, the "Next" button is not shown.