Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parallel-execution.md with clarifications on Feature behavior with method-level parallelism #364

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

DrEsteban
Copy link
Contributor

@DrEsteban DrEsteban commented Dec 20, 2024

🤔 What's changed?

Updating the sections that call out the considerations that need to be made when using Feature-level behavior and context with method-level parallelism enabled.

  • Clarifying that concern mostly exists with method-level parallelism rather than class-level parallelism
  • Adding additional details on what the user can expect if they still choose to enable method-level parallelism

⚡️ What's your motivation?

#345

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

  • Am I correct in clarifying the concern really only exists for method-level parallelism?
  • Are the new clarifications too verbose?

📋 Checklist:

  • [ ] I've changed the behaviour of the code
    • [ ] I have added/updated tests to cover my changes.
  • [ ] My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

@DrEsteban
Copy link
Contributor Author

@obligaron @gasparnagy Any feedback on this idea or implementation?

@DrEsteban DrEsteban requested a review from obligaron January 7, 2025 22:13
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@gasparnagy gasparnagy merged commit 1ab7ee0 into reqnroll:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants