MSDI: Support returning IServiceProvider
scenario dependencies with the ME.DI plugin
#383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The ME.DI plugin can now return an
IServiceProvider
from the static method, in addition to supporting theIServiceCollection
type.⚡️ What's your motivation?
This supports scenarios when integration testing ASP.NET Core projects, where we have a service container built and owned by the
WebApplicationFactory
(or other scenarios). The downside is that you must manually register the bindings, but there is already precedent for this in the Windsor plugin, where we have to do the same.There is no change to the public API other than being able to return
IServiceProvider
from the static method. TheAutoRegisterBindings
setting is ignored when returningIServiceProvider
and I've added some xmldoc comments to that effect.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.