Source keyword arguments #3457
Merged
Source keyword arguments #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix! Sorry I overlooked it in the previous implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataloader is currently breaking in Ruby 3 when used with sources that have keyword arguments in their constructor. The splat operator in
Dataloader#withis transforming the keyword arguments into a hash and if we then try it initialize the source with that hash, it crashes.This PR fixes that.
MRI supports the new syntax since v2.7 but apparently, that's not the case for TruffleRuby. That's why I'm only using it in Ruby 3. In general, I'm not a fan of having to duplicate code for different ruby versions but I couldn't come up with a better way to make this backward-compatible. 🤔