Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and refactor e2e tests #1898

Merged
merged 25 commits into from
Jan 22, 2025
Merged

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Jan 6, 2025

Describe your changes

Groups all e2e scenarios into trigger and no trigger divided by categories to improve performance of test execution.

What changed:

  • Tests are now grouped in Trigger and NoTrigger scenarios
  • Reset of DB happens only once per group test execution and is redone when test fails for the first time (eg. due to timeout or network issue)
  • Instances are initiated only once per group of tests

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

Aim of this refactor was to reduce the time needed for the e2e test execution and create a space in groups for the future tests.

@Piotrk39 Piotrk39 added enhancement New feature or request test This involves testing labels Jan 6, 2025
@Piotrk39 Piotrk39 changed the title Group "Map" e2e tests Group and refactor e2e tests Jan 7, 2025
@Piotrk39 Piotrk39 marked this pull request as ready for review January 8, 2025 14:00
@Piotrk39 Piotrk39 force-pushed the feat.refactor-and-group-e2e-tests branch from 75e2c1d to e95cdd5 Compare January 12, 2025 11:43
@Piotrk39 Piotrk39 mentioned this pull request Jan 21, 2025
3 tasks
@Piotrk39
Copy link
Contributor Author

@gulfaraz I took a look at this PR and the one with fixes from @jannisvisser . It looks like a tremendous effort was put into refactoring of this framework. Hats off to all of us 🚀

@jannisvisser jannisvisser merged commit 121fbaa into master Jan 22, 2025
7 checks passed
@jannisvisser jannisvisser deleted the feat.refactor-and-group-e2e-tests branch January 22, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test This involves testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants