-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group and refactor e2e tests #1898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piotrk39
force-pushed
the
feat.refactor-and-group-e2e-tests
branch
from
January 12, 2025 11:43
75e2c1d
to
e95cdd5
Compare
…s-between-two-groups Split tests between two groups
refactor: use describe to group e2e tests
refactor: make e2e code somewhat disaster-type agnostic AB#32759
3 tasks
fix: flaky e2e tests AB#32712
@gulfaraz I took a look at this PR and the one with fixes from @jannisvisser . It looks like a tremendous effort was put into refactoring of this framework. Hats off to all of us 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Groups all e2e scenarios into trigger and no trigger divided by categories to improve performance of test execution.
What changed:
Checklist before requesting a review
Notes for the reviewer
Aim of this refactor was to reduce the time needed for the e2e test execution and create a space in groups for the future tests.