Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky map/ legend/ aggregates e2e test #1935

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix flaky map/ legend/ aggregates e2e test #1935

merged 1 commit into from
Jan 24, 2025

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Jan 22, 2025 •
edited
Loading

Describe your changes

Fixes random failures of the test when locator couldn't be found and actions were executed in random order.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

Added:

  1. Await for domContentLoaded
  2. Await for networkIdle
  3. 200ms await before hovering over the map

@Piotrk39 Piotrk39 requested a review from jannisvisser January 22, 2025 15:55
@jannisvisser jannisvisser merged commit 5222c09 into master Jan 24, 2025
7 checks passed
@jannisvisser jannisvisser deleted the fix.flaky-aggregates-test branch January 24, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannisvisser jannisvisser jannisvisser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piotrk39 @jannisvisser