Merge branch '378-remove-keygen' into 'dev'

remove keygen scenario from guard-service

Closes #378

See merge request ergo/rosen-bridge/guard-service!358

.changeset/early-carrots-buy.md

@@ -0,0 +1,5 @@
+---
+'guard-service': patch
+---
+
+remove keygen scenario from guard-service

config/default.yaml

@@ -162,8 +162,3 @@ healthCheck:
     defectConfirmationTimeWindow: 120 # Time to wait after any peer disconnection
 revenue:
   interval: 120 # revenue update interval
-keygen: # only set when you want to start keygen process
-  active: false # set true to start keygen process on startup
-  guards: 0 # total number of guards
-  threshold: 0 # signing threshold (at least threshold + 1 guards are required)
-  algorithm: eddsa # keygen algorithm. only eddsa supported

src/configs/Configs.ts

@@ -5,7 +5,7 @@ import { ThresholdConfig } from '../coldStorage/types';
 import { JsonBI } from '../network/NetworkModels';
 import Utils from '../utils/Utils';
 import { ConfigError } from '../utils/errors';
-import { SUPPORTED_CHAINS, TssAlgorithms } from '../utils/constants';
+import { SUPPORTED_CHAINS } from '../utils/constants';
 import { TransportOptions } from '@rosen-bridge/winston-logger';
 import { cloneDeep } from 'lodash-es';
 
@@ -49,23 +49,6 @@ const getOptionalConfig = <T>(key: string, defaultValue: T) => {
   return defaultValue;
 };
 
-const SupportedAlgorithms: string[] = [
-  TssAlgorithms.curve,
-  TssAlgorithms.edward,
-];
-class KeygenConfig {
-  static isActive = config.get<boolean>('keygen.active');
-  static guardsCount = getConfigIntKeyOrDefault('keygen.guards', 0);
-  static threshold = getConfigIntKeyOrDefault('keygen.threshold', 0);
-  static algorithm = () => {
-    const algorithm = config.get<string>('keygen.algorithm');
-    if (SupportedAlgorithms.indexOf(algorithm) !== -1) {
-      return algorithm;
-    }
-    throw Error(`Invalid keygen algorithm ${algorithm}`);
-  };
-}
-
 class Configs {
   // express config
   static apiPort = getConfigIntKeyOrDefault('api.port', 8080);
@@ -110,7 +93,6 @@ class Configs {
   static tssUrl = config.get<string>('tss.url');
   static tssPort = config.get<string>('tss.port');
   static tssBaseCallBackUrl = `http://${this.apiHost}:${this.apiPort}/tss/sign`;
-  static tssKeygenCallBackUrl = `http://${this.apiHost}:${this.apiPort}/tss/keygen`;
   static tssKeys = {
     secret: config.get<string>('tss.secret'),
     pubs: config.get<
@@ -316,7 +298,6 @@ class Configs {
     'revenue.interval',
     120
   );
-  static keygen = KeygenConfig;
 }
 
 export default Configs;

src/guard/Tss.ts

@@ -7,9 +7,7 @@ import {
   StatusEnum,
   TssSigner,
 } from '@rosen-bridge/tss';
-import axios from 'axios';
 import * as crypto from 'crypto';
-import CommunicationConfig from '../communication/CommunicationConfig';
 import Dialer from '../communication/Dialer';
 import Configs from '../configs/Configs';
 import { spawn } from 'child_process';
@@ -196,52 +194,6 @@ class Tss {
     );
   };
 
-  /**
-   * start keygen process for guards
-   * @param guardsCount
-   * @param threshold
-   */
-  static keygen = async (guardsCount: number, threshold: number) => {
-    Tss.runBinary();
-
-    // initialize dialer
-    Tss.dialer = await Dialer.getInstance();
-
-    Tss.tryCallApi(guardsCount, threshold);
-  };
-
-  /**
-   * wait until all peers are connected then call tss keygen api
-   * @param guardsCount
-   * @param threshold
-   */
-  private static tryCallApi = (guardsCount: number, threshold: number) => {
-    const peerIds = Tss.dialer
-      .getPeerIds()
-      .filter((peerId) => !CommunicationConfig.relays.peerIDs.includes(peerId));
-    if (peerIds.length < guardsCount - 1 || !Tss.dialer.getDialerId()) {
-      setTimeout(() => Tss.tryCallApi(guardsCount, threshold), 1000);
-    } else {
-      setTimeout(() => {
-        axios
-          .post(`${Configs.tssUrl}:${Configs.tssPort}/keygen`, {
-            p2pIDs: [Tss.dialer.getDialerId(), ...peerIds],
-            callBackUrl: Configs.tssKeygenCallBackUrl,
-            crypto: Configs.keygen.algorithm(),
-            threshold: threshold,
-            peersCount: guardsCount,
-            operationTimeout: 10 * 60, // 10 minutes
-          })
-          .then((res) => {
-            logger.info(JSON.stringify(res.data));
-          })
-          .catch((err) => {
-            logger.error(`an error occurred during call keygen ${err}`);
-            logger.debug(err.stack);
-          });
-      }, 10000);
-    }
-  };
   /**
    * generates a function to wrap channel send message to dialer
    * @param channel

src/index.ts

@@ -21,7 +21,7 @@ import GuardPkHandler from './handlers/GuardPkHandler';
 import MinimumFeeHandler from './handlers/MinimumFeeHandler';
 import { minimumFeeUpdateJob } from './jobs/minimumFee';
 
-const initService = async () => {
+const init = async () => {
   // initialize Notification object
   await Notification.getInstance();
 
@@ -72,19 +72,4 @@ const initService = async () => {
   await revenueJob();
 };
 
-const initKeygen = async () => {
-  // initialize express Apis
-  await initApiServer();
-
-  await Tss.keygen(Configs.keygen.guardsCount, Configs.keygen.threshold);
-};
-
-const init = async () => {
-  if (Configs.keygen.isActive) {
-    return initKeygen();
-  } else {
-    return initService();
-  }
-};
-
 init().then(() => null);

src/jobs/apiServer.ts

@@ -3,7 +3,6 @@ import fastify, { FastifyInstance, FastifyRequest } from 'fastify';
 import swagger from '@fastify/swagger';
 import swaggerUi from '@fastify/swagger-ui';
 import { TypeBoxTypeProvider } from '@fastify/type-provider-typebox';
-import { keygenRoute } from '../api/keygen';
 import { p2pRoutes } from '../api/p2p';
 import Configs from '../configs/Configs';
 import { generalInfoRoute } from '../api/generalInfo';
@@ -96,17 +95,14 @@ const initApiServer = async () => {
   });
 
   await apiServer.register(p2pRoutes);
-  if (Configs.keygen.isActive) {
-    await apiServer.register(keygenRoute);
-  } else {
-    await apiServer.register(tssRoute);
-    await apiServer.register(generalInfoRoute);
-    await apiServer.register(eventRoutes);
-    await apiServer.register(healthRoutes);
-    await apiServer.register(revenueRoutes);
-    await apiServer.register(assetRoutes);
-    await apiServer.register(signRoute);
-  }
+  await apiServer.register(tssRoute);
+  await apiServer.register(generalInfoRoute);
+  await apiServer.register(eventRoutes);
+  await apiServer.register(healthRoutes);
+  await apiServer.register(revenueRoutes);
+  await apiServer.register(assetRoutes);
+  await apiServer.register(signRoute);
+
   apiServer.get('/', (request, reply) => {
     reply.redirect('/swagger');
   });