Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowflake Cortex Integration #17585

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

q-maze
Copy link

@q-maze q-maze commented Jan 22, 2025

Description

Add integration with Snowflake Cortex LLMs.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 22, 2025
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but one minor nit

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 23, 2025 21:02
auto-merge was automatically disabled January 23, 2025 21:30

Head branch was pushed to by a user without write access

@q-maze
Copy link
Author

q-maze commented Jan 23, 2025

Added missing aiohttp as a dependency

@logan-markewich logan-markewich enabled auto-merge (squash) January 23, 2025 22:42
@q-maze
Copy link
Author

q-maze commented Jan 23, 2025

Not sure why cryptography isn't in the environment? Its in my local env. I'll look into it more tomorrow.

@q-maze
Copy link
Author

q-maze commented Jan 24, 2025

Added missing aiohttp as a dependency

Not sure why cryptography isn't in the environment. Its in my local env. I'll look into it more tomorrow.

Don't do a lot of poetry, but aiohttp is a dependency of llama-index-core, so not sure why I had to add that? I went ahead and added cryptography to the dependencies, but it will only work for certain versions of Python 3.9.

auto-merge was automatically disabled January 24, 2025 16:38

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants