Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update infrastructure to use macOS 14 #496

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

weikequ
Copy link
Contributor

@weikequ weikequ commented Nov 28, 2023

Issue #, if available:

Description of changes:

  • Update infrastructure to support macOS 14

Testing done:
-npm run test

  • Wrote new tests for the ASG runner stack

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@weikequ weikequ self-assigned this Nov 28, 2023
Signed-off-by: Weike Qu <weikequ@amazon.com>
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked the AMIs, LGTM. Nice job adding the tests and fixing formatting.

@weikequ weikequ merged commit 7067043 into runfinch:main Nov 29, 2023
2 checks passed
@weikequ weikequ deleted the update-to-sonoma branch November 29, 2023 19:08
weikequ added a commit to runfinch/finch-core that referenced this pull request Dec 7, 2023
Issue #, if available:
- runfinch/finch#680

*Description of changes:*
- runfinch/infrastructure#496
- Updated CI to use 14 for e2e testing

*Testing done:*
- none


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Weike Qu <weikequ@amazon.com>
weikequ added a commit to runfinch/finch that referenced this pull request Dec 7, 2023
Issue #, if available:
- Closes #680

*Description of changes:*
- runfinch/infrastructure#496
- Removed the docker-compat e2e tests in the corresponding ci-docs left
over from #524

*Testing done:*
- none

- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Weike Qu <weikequ@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants