Include default_version by default
#10344
Conversation
eth3lbert
force-pushed
the
app-default-version
branch
from
a03882a to
ddfede2
Compare
| /** @return {Map<string, import("../models/version").default>} */ | ||
| @cached | ||
| get loadedVersionsByNum() { | ||
| let versionsRef = this.hasMany('versions'); | ||
| let values = versionsRef.value(); | ||
| return new Map(values?.map(ref => [ref.num, ref])); | ||
| } |
There was a problem hiding this comment.
I think versionsObj could also be changed to implement in this way. This would allow all versions that belong to this crate to be available, rather than just those loaded via the loadVersionsTask.
|
I have removed a commit that aimed to only await |
eth3lbert
force-pushed
the
app-default-version
branch
from
ddfede2 to
bfe8d72
Compare
|
Rebased to make CI happy after the new Danger Zone was added :D |
eth3lbert
force-pushed
the
app-default-version
branch
2 times, most recently
from
96786e2 to
433abe7
Compare
This commit would ensure that `default_version` is included in the `crate` response by default. This eliminates the need to wait for the `versions` request to complete when `default_version` is the only version required.
eth3lbert
force-pushed
the
app-default-version
branch
from
433abe7 to
59a975b
Compare
|
Rebased! |
app/routes/crate/version.js
Outdated
| (await this.store | ||
| .queryRecord('version', { | ||
| name: crate.id, | ||
| num: requestedVersion, | ||
| }) | ||
| .catch(() => { | ||
| // ignored | ||
| })); |
There was a problem hiding this comment.
if we still use crate.loadVersionsTask above, what is the reason for this fallback? 🤔
There was a problem hiding this comment.
Yes, that's a completely fair question. We still have dependencies on the versions (especially the version count), which makes the fallback seem unnecessary. The fallback would become valuable if we could load the page without blocking to wait for versions.
|
also, sorry for keeping you waiting on this. I totally forgot about this PR 😞 |
eth3lbert
force-pushed
the
app-default-version
branch
from
59a975b to
901fc09
Compare
…ame}/{version}` endpoint
Previously, we fetched all versions and then found the requested version within them. This commit changes the approach to either retrieve the version from loaded versions or fetch it from the endpoint. This change allows us to migrate to paginated versions in the future.
eth3lbert
force-pushed
the
app-default-version
branch
from
901fc09 to
859959f
Compare
This PR would ensure that
default_versionis included in thecrateresponse by default. This eliminates the need to wait for theversionsrequest to complete whendefault_versionis the only version required. This also decouples requested version handling from versions.Related:
default_versioninclude mode #10288