Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification page implemented resolves enhacement request #546 #553

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

saltykheera
Copy link
Contributor

@saltykheera saltykheera commented Jan 21, 2025

#546
#546
notification are categeorizes in two section
A> unread
b> inbox
inbox consist of all the notification user has requested where as
unread consist of notification which are not read

@marcgc21
Copy link
Member

I think that we are moving to a nice update of the system! However, I still have concerns about those notifications dissapearing.

Can you update the system to avoid cleaning the notifications? Right now I'm not sure if it is a database delete or it is just a filter state on the render visualization. Can you confirm that?

@marcgc21
Copy link
Member

marcgc21 commented Jan 23, 2025

@saltykheera Also, try to update from the develop branch, I think that it solves part of the problems of the CI pipeline!

@saltykheera
Copy link
Contributor Author

I think that we are moving to a nice update of the system! However, I still have concerns about those notifications dissapearing.

Can you update the system to avoid cleaning the notifications? Right now I'm not sure if it is a database delete or it is just a filter state on the render visualization. Can you confirm that?

the notification once read are deleted
and are not saved in database
hence , the past notifications can't be recovered but after this pr is merged
the notification will then start to get stored in the database

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants