This repository has been archived by the owner on Mar 18, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
5d703e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very interested in porting malli-cli on babashka! The reason why I haven't moved from Leiningen to deps.edn completely is because the automation tooling I use is a bit drafty as of now, and only focuses on deps.edn.
That being said, if there is anything I may do to ease the port, just let me know. Very enthusiastic about reviewing any PR, commenting any issues, and discussing ideas about how to make it happen.
5d703e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @piotr-yuxuan,
Re babashka,
I initally made a babashka script, but when added started adding CLI support to it with malli-cli I converted it to just deps.edn based script. I must say, I did not made an investigation, just briefly looked through the problem and it looked that malli itself doesn't seem to work out of the box with babashka. At least not the malli imported with
babashka.deps/add-deps
. I don't remember the issue. I found a pod-babashka-malli, but then well, assuming malli-cli requires malli, I assumed it would not work. That is why I just moved to deps.edn for this case. At the end the boot start does not matter for me at this stage, and launching Clojure via deps.edn is good enough.Re adding deps.edn
to be honest I added deps.edn on top of the change in my fork only to feed my script's deps.edn with a fixed malli-cli, via deps tools support for using git, e.g.
Once the change is merged, I'll simply upgrade the version and dump the fork, including this commit :)
5d703e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-yp here: piotr-yuxuan#23