-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging SIMD parts #263
Open
lamphamsy
wants to merge
77
commits into
eh/rework_simd
Choose a base branch
from
clean/merge_simd_parts
base: eh/rework_simd
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merging SIMD parts #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Essential operations - simd_128.h contains essential wrappers of SIMD operations on SSE - simd_256.h contains essential wrappers of SIMD operations on AVX 2. Basic operations - simd_basic.h contain basic operations used in following cases, and also operations for RingModN 3. Vectorized operations - simd_fnt.h contains vectorized operations dedicated for FNT - simd_nf4.h contains vectorized operations dedicated for nf4
It implements basic operations that will be used everywhere. It includes also operations for RingModN
It moves typedef for DoubleSize and SignedDoubleSize from arith to core
I think it's too early to merge things now. I was developing my stuff inside a "simd" subdirectory to avoid conflict with the current SIMD implementation. |
lamphamsy
force-pushed
the
eh/rework_simd
branch
from
November 22, 2018 18:03
05d3938
to
d79d7a1
Compare
lamphamsy
force-pushed
the
eh/rework_simd
branch
6 times, most recently
from
December 2, 2018 05:02
29358aa
to
9302df1
Compare
lamphamsy
force-pushed
the
eh/rework_simd
branch
from
December 10, 2018 15:42
ed316e9
to
b53d062
Compare
lamphamsy
force-pushed
the
eh/rework_simd
branch
4 times, most recently
from
December 20, 2018 13:15
ed7127e
to
9c47e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It merges SIMD parts together.
It waits for