add LegacyEnoteOriginContext

[SNeedlewoods]

The changes quickly added up to get around compiler errors. Now it builds fine, but fails at unit_tests seraphis_enote_scanning.trivial_ledger. Before I go too deep in the complete wrong direction, some feedback would be appreciated.
I added comments with QUESTION and TODO (without a well defined distinction), for things I currently focus on.

---

Edit after squash:
this PR adds:

• LegacyEnoteOriginContextV1 for pre-RingCT enotes which get indexed by enote_same_amount_ledger_index
• LegacyEnoteOriginContextV2 for post-RingCT enotes which get indexed by rct_enote_ledger_index
• LegacyEnoteOriginContextVariant which contains either V1 or V2 contexts
• a bool is_pre_rct to LegacyEnoteV1 to help differentiate between V1 and V2 contexts
• function to create pre-RingCT LegacyEnoteV1
• some *_ref functions
• constructors for LegacyContextual(Intermediate)EnoteRecords to set the LegacyEnoteOriginContextVariant to the correct type or to default type post-RingCT
• functionality for the new indexes in the scanner and mock ledger
• tests in seraphis_enote_scanning: legacy_pre_rct_1 & legacy_coinbase_1

Feel free to review.

[j-berman]

Quick first pass, it's looking like a good start. Thank you :)

[SNeedlewoods]

Minor update, now failing 16 tests
seraphis_enote_scanning.legacy_pre_transition_*
seraphis_enote_scanning.legacy_sp_transition_*
seraphis_integration.txtype_squashed_v1
seraphis_multisig.txtype_squashed_v1

[SNeedlewoods]

still not done, but the last one was a big baby step for me

not worth a review at this point, I think, I have an idea what to do next

[SNeedlewoods]

At this stage I'd like to get some feedback.
Should I add something?
e.g. there are no tests for LegacyEnoteV4 in seraphis_enote_scanning.cpp
Are there too many or too few checks for ledger_context.get_legacy_amount_counts in seraphis_enote_scanning.cpp?
Have I missed something?

[UkoeHB]

Small review

[rbrunner7]

Something looks very wrong currently with your PR, with 165 commits. I would guess either you did not yet rebase to the new state of our seraphis_wallet branch, or you did rebase but something went wrong.

[rbrunner7]

I am sorry to not have noticed, and asked this question much earlier already, as only now I finally had a look at the files that this PR modifies: They are all Seraphis library files, right? Thus seems to me this should be a PR to the Seraphis library, not to here.

I believe following a rule "Seraphis library modifications always to @UkoeHB's Seraphis library repo and branch" will make rebasing / updating our Seraphis wallet branch easier, and it be clearer where to find what.

[rbrunner7]

I had a look at the PR nevertheless, to check whether I could review, and found out that it's too specific for me, I lack both the necessary detailed knowledge about the protocols involved with all these types of transactions and enotes, and knowledge about the workings of the Seraphis library ...