Rework Windows resources hack to not depend on resource path strings #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing CI tests it is important to also test that the install itself works. However, due to how precompilation works with staging repositories the fastest way to both run the tests and test the actual install is to run `zef install .`. Doing so avoids an extra round of precompilation over doing a test step followed by an install step.
Previously we were copying dll files from resources to a different location so that the files could continue having the same file name. There was also a hack to avoid doing that copy and to use the included dll files directly if it determined those resources already had the expected basename (such as a non-installed openssl). The hack relied on using now deprecated methods, but realistically we don't need it. This reworks the logic on Windows for copying a resource file to always occur regardless of what repository has loaded it. By doing so it fixes some deprecation messages from rakudo about treating resource objects like path strings. See: rakudo/rakudo#5507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rakudo recently started emitting deprecation messages when
%?RESOURCESwas treated like a path string (see rakudo/rakudo#5507). That affects these openssl bindings because a windows-specific hack was using the base file name of a%?RESOURCEentry, which would cause the aforementioned deprecation messages to be emitted. This PR reworks the hack to not depend on any part of the path name.