Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WebApp #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"eslint-plugin-import": "2.20.2",
"eslint-plugin-vue": "6.2.2",
"express": "4.17.1",
"favicons-webpack-plugin": "3.0.1",
"file-loader": "5.1.0",
"html-webpack-plugin": "4.0.0-beta.5",
"mini-css-extract-plugin": "0.9.0",
Expand Down
Binary file removed src/assets/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="theme-color" content="#af1a1b">
<title>Trakt Playback Progress Manager</title>
<meta name="title" content="Trakt Playback Progress Manager">
<meta name="description" content="Manage playback progress items stored on Trakt.tv" />
Expand Down
17 changes: 16 additions & 1 deletion webpack.config.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import MiniCssExtractPlugin from 'mini-css-extract-plugin';
import { DefinePlugin } from 'webpack';
import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer';
import NullPlugin from 'webpack-null-plugin';
import FaviconsWebpackPlugin from 'favicons-webpack-plugin';

import pkg from './package.json';

Expand Down Expand Up @@ -147,7 +148,6 @@ const webpackConfig = (env, mode) => ({
new CleanWebpackPlugin(),
new HtmlWebpackPlugin({
template: path.resolve(__dirname, 'src/index.html'),
favicon: path.resolve(__dirname, 'src/assets/favicon.ico'),
minify: mode === 'production' && {
// Defaults: https://git.io/fj8Qn
// https://github.com/kangax/html-minifier#options-quick-reference
Expand All @@ -161,6 +161,21 @@ const webpackConfig = (env, mode) => ({
minifyCSS: true,
},
}),
new FaviconsWebpackPlugin({
logo: path.resolve(__dirname, 'src/assets/tppm.svg'),
prefix: '',
publicPath: '',
favicons: {
/* eslint-disable camelcase */
appName: pkg.description,
appShortName: pkg.name.toUpperCase(),
appDescription: 'Manage the playback progress items stored on your Trakt.tv account.',
start_url: './',
background: '#ffffff',
theme_color: '#af1a1b',
/* eslint-enable camelcase */
},
}),
new VueLoaderPlugin(),
new MiniCssExtractPlugin({
filename: `[name]${NOT_DEV_SERVER ? '.[contenthash:8]' : ''}.css`,
Expand Down
Loading