[WIP] Adds h5py dump

[pluflou]

No description provided.

[roussel-ryan]

can we keep the elif isinstance statements going for the other types, incl. string and ndarrays? Better to be explicit. Maybe just call str() on types that do not match anything

[pluflou]

you mean like this? If we call str() on the else statement, then the numpy data structures won't be saved as numpy types

                elif isinstance(val, dict):
                    group = f.create_group(key, track_order=True)
                    recursive_save(val, group)
                elif isinstance(val, str):
                    f.create_dataset(key, data=val, dtype=dt, track_order=True)
                else:
                    f.create_dataset(key, data=val, track_order=True)

[roussel-ryan]

yes, but add an isinstance(val, np.ndarray) block in there

[pluflou]

How about the updated code?

        ...

        self.supported_types = (bool, int, float, np.ndarray, np.integer, np.floating)

        ...
                elif isinstance(val, self.supported_types):
                    f.create_dataset(key, data=val, track_order=True)
                elif isinstance(val, str):
                    # specify string dtype to avoid issues with encodings
                    f.create_dataset(key, data=val, dtype=dt, track_order=True)
                else:
                    f.create_dataset(key, data=str(val), track_order=True)