Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move interface logic into their logical files #889

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Move interface logic into their logical files #889

merged 9 commits into from
Jan 5, 2024

Conversation

thvdveld
Copy link
Contributor

@thvdveld thvdveld commented Jan 5, 2024

This is just cleaning up src/iface/interface/mod.rs making that file more readable and maintainable.

@thvdveld
chore(iface): move udp into own file
d96dd73 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(tcp): move tcp processing to own file
0fe828b 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(ethernet): rm unused feature flags/imports
54d906f 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(igmp): remove unused imports
0a0eff2 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(sixlowpan): all 6lowpan logic into sixlowpan
e22ec0a 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(ieee): all logic in ieee802154.rs
3855338 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(ipv4): all logic into ipv4.rs
83900c6 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
chore(ipv6): all logic into ipv6.rs
df94104 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@thvdveld
change(neigh): flush_cache to flush_neighbor_cache
f25c66d 
Signed-off-by: Thibaut Vandervelden <thvdveld@vub.be>
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (4877a39) 79.75% compared to head (f25c66d) 79.75%.

Files Patch % Lines
src/iface/interface/ipv4.rs 58.62% 24 Missing ⚠️
src/iface/interface/sixlowpan.rs 62.85% 13 Missing ⚠️
src/iface/interface/ipv6.rs 88.67% 12 Missing ⚠️
src/iface/interface/udp.rs 88.88% 6 Missing ⚠️
src/iface/interface/tcp.rs 82.75% 5 Missing ⚠️
src/iface/interface/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files          78       80    +2     
  Lines       28036    28033    -3     
=======================================
- Hits        22359    22358    -1     
+ Misses       5677     5675    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Jan 5, 2024
Merged via the queue into smoltcp-rs:main with commit 5ee728a Jan 5, 2024
11 checks passed
@thvdveld thvdveld deleted the clean-up branch January 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thvdveld