Re-export dhcpv4::Flags and dhcpv4::OpCode
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
=======================================
Coverage 79.92% 79.92%
=======================================
Files 80 80
Lines 28234 28234
=======================================
Hits 22566 22566
Misses 5668 5668 ☔ View full report in Codecov by Sentry. |
Databean
force-pushed
the
expose_dhcp_opcode
branch
from
e6f1ff4 to
fd4298e
Compare
Similar to issue smoltcp-rs#762 and PR smoltcp-rs#763, `DhcpPacket::set_flags` and `DhcpPacket::set_opcode` were not usable externally because `dhcpv4::Flags` and `dhcpv4::OpCode` were private types. Re-export these types as `smoltcp::wire::DhcpFlags` and `smoltcp::wire::DhcpOpCode`.
Databean
force-pushed
the
expose_dhcp_opcode
branch
from
fd4298e to
9c422f8
Compare
Databean
changed the title
dhcpv4::Flags and dhcpv4::OpCode
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to issue #762 and PR #763,
DhcpPacket::set_flagsandDhcpPacket::set_opcodewere not usable externally becausedhcpv4::Flagsanddhcpv4::OpCodewere private types. Re-export these types assmoltcp::wire::DhcpFlagsandsmoltcp::wire::DhcpOpCode.