WIP Clean up and fix various pylint issues

.pylintrc

@@ -19,7 +19,7 @@ ignore-patterns=
 
 # Use multiple processes to speed up Pylint. Specifying 0 will auto-detect the
 # number of processors available to use.
-jobs=1
+jobs=0
 
 # Control the amount of potential inferred values when inferring a single
 # object. This can help the performance when dealing with large functions or
@@ -28,7 +28,11 @@ limit-inference-results=100
 
 # List of plugins (as comma separated values of python modules names) to load,
 # usually to register additional checkers.
-load-plugins=
+load-plugins=pylint.extensions.check_elif,
+             pylint.extensions.bad_builtin,
+             pylint.extensions.redefined_variable_type,
+             pylint.extensions.overlapping_exceptions,
+             pylint.extensions.emptystring,
 
 # Pickle collected data for later comparisons.
 persistent=yes
@@ -62,33 +66,14 @@ confidence=
 # --disable=W".
 disable=invalid-name,
         missing-docstring,
+        ungrouped-imports,
+        too-few-public-methods,
         too-many-arguments,
         too-many-locals,
-        too-few-public-methods,
-        too-many-return-statements,
-        inconsistent-return-statements,
-        redefined-outer-name,
         too-many-branches,
-        unused-argument,
-        broad-except,
         too-many-instance-attributes,
-        no-self-use,
-        ungrouped-imports,
         too-many-statements,
-        wrong-import-position,
-        trailing-whitespace,
-        useless-object-inheritance,
-        no-name-in-module,
-        superfluous-parens,
-        function-redefined,
         too-many-ancestors,
-        arguments-differ,
-        duplicate-string-formatting-argument,
-        simplifiable-if-expression,
-        implicit-str-concat-in-sequence,
-        abstract-method,
-        literal-comparison,
-        protected-access
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
@@ -472,7 +457,7 @@ max-parents=7
 max-public-methods=20
 
 # Maximum number of return / yield for function / method body.
-max-returns=6
+max-returns=8
 
 # Maximum number of statements in function / method body.
 max-statements=50

cloudbot/__init__.py

@@ -1,15 +1,14 @@
+import json
+import logging
+import logging.config
+import os
 import sys
 
 # check python version
 if sys.version_info < (3, 5, 0):
     print("CloudBot requires Python 3.5 or newer.")
     sys.exit(1)
 
-import json
-import logging.config
-import logging
-import os
-
 __version__ = "1.0.9"
 
 __all__ = ["clients", "util", "bot", "client", "config", "event", "hook", "permissions", "plugin", "reloader",

cloudbot/__main__.py

@@ -15,12 +15,12 @@
 sys.path.insert(0, str(install_dir))
 os.chdir(str(install_dir))
 
-# import bot
-from cloudbot.bot import CloudBot
-from cloudbot.util import async_util
-
 
 def main():
+    # import bot
+    from cloudbot.bot import CloudBot
+    from cloudbot.util import async_util
+
     # Logging optimizations, doing it here because we only want to change this if we're the main file
     logging._srcfile = None
     logging.logThreads = 0
@@ -42,7 +42,7 @@ def main():
     # The handler is called with two arguments: the signal number and the current stack frame
     # These parameters should NOT be removed
     # noinspection PyUnusedLocal
-    def exit_gracefully(signum, frame):
+    def exit_gracefully_cb(signum, frame):
         nonlocal stopped_while_restarting
         if not _bot:
             # we are currently in the process of restarting
@@ -55,7 +55,7 @@ def exit_gracefully(signum, frame):
         # restore the original handler so if they do it again it triggers
         signal.signal(signal.SIGINT, original_sigint)
 
-    signal.signal(signal.SIGINT, exit_gracefully)
+    signal.signal(signal.SIGINT, exit_gracefully_cb)
 
     # start the bot master
 

cloudbot/bot.py

@@ -190,7 +190,8 @@ def run(self):
         self.loop.close()
         return restart
 
-    def get_client(self, name: str) -> Type[Client]:
+    @staticmethod
+    def get_client(name: str) -> Type[Client]:
         return CLIENTS[name]
 
     def create_connections(self):

cloudbot/client.py

@@ -95,7 +95,7 @@ async def try_connect(self):
         while self.active and not self.connected:
             try:
                 await self.connect(timeout)
-            except Exception:
+            except Exception:  # pylint: disable=broad-except
                 logger.exception("[%s] Error occurred while connecting.", self.name)
             else:
                 break