Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-dotnet] instrumentation configuration doc improvements #1109

Merged
merged 6 commits into from
Jan 10, 2024
Merged

[otel-dotnet] instrumentation configuration doc improvements #1109

merged 6 commits into from
Jan 10, 2024

Conversation

lachmatt
Copy link
Contributor

Requirements

  • Content follows Splunk guidelines for style and formatting.
  • You are contributing original content.

Describe the change

Instrumentation configuration description improvements.
@pellared PTAL

@lachmatt lachmatt requested a review from a team as a code owner December 28, 2023 09:50
@aurbiztondo-splunk aurbiztondo-splunk added the stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise label Dec 28, 2023
pellared
pellared approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nit formatting suggestions

gdi/get-data-in/application/otel-dotnet/instrumentation/instrument-dotnet-application.rst Outdated Show resolved Hide resolved
gdi/get-data-in/application/otel-dotnet/instrumentation/instrument-dotnet-application.rst Outdated Show resolved Hide resolved
@theletterf theletterf self-assigned this Jan 10, 2024
theletterf
theletterf approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theletterf theletterf merged commit 9e3e108 into splunk:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@theletterf theletterf theletterf approved these changes

Assignees

@theletterf theletterf

Labels
external stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lachmatt @theletterf @pellared @aurbiztondo-splunk @srv-rpa-o11y-docs-splunk