Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect browser test metric (DNS time) #1128

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Remove incorrect browser test metric (DNS time) #1128

merged 4 commits into from
Jan 11, 2024

Conversation

robertam3
Copy link
Contributor

@robertam3 robertam3 commented Jan 11, 2024 •
edited
Loading

Requirements

  • Content follows Splunk guidelines for style and formatting.
  • You are contributing original content.

Describe the change

  • Removed synthetics.dns.time.ms since that is not available for Browser tests (instead the metric is called synthetics.first_request.dns.time.ms
  • Removed whitespace (this is in a separate commit to make things easier to review)
  • Updated the documented lighthouse version now that we are on v10
  • Removed references to Response Time in the definition for the page duration --

image

If this contribution is time sensitive, tell us when you'd like this PR to be merged.

@robertam3
Auto-remove extra whitespace
abb1c03
@robertam3
Remove dns time from browser page metrics
449f1a9 
The metric is synthetics.first_request.dns.time.ms which is already documented on this page.
@robertam3
Remove references to response time
5707ee8 
Response time for browser tests is a holdover from legacy.
@robertam3
Update lighthouse version
a83d6dc
@robertam3 robertam3 requested a review from a team as a code owner January 11, 2024 19:20
@gschatz-splunk gschatz-splunk self-assigned this Jan 11, 2024
@gschatz-splunk gschatz-splunk added the stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise label Jan 11, 2024
gschatz-splunk
gschatz-splunk approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@gschatz-splunk gschatz-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible ! thank you <3

@gschatz-splunk gschatz-splunk merged commit 2172e72 into splunk:main Jan 11, 2024
2 checks passed
@robertam3 robertam3 deleted the rrl/remove-incorrect-browser-test-metric branch January 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschatz-splunk gschatz-splunk gschatz-splunk approved these changes

Assignees

@gschatz-splunk gschatz-splunk

Labels
external stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertam3 @gschatz-splunk @srv-rpa-o11y-docs-splunk