Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manual-rum-browser-instrumentation.rst #1655

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update manual-rum-browser-instrumentation.rst #1655

merged 2 commits into from
Jan 23, 2025

Conversation

jelkhouri-splunk
Copy link
Contributor

Added importing splunk/otel-web for the "set the user id on all spans" example

Requirements

  • [x ] Content follows Splunk guidelines for style and formatting.
  • [x ] You are contributing original content.

Describe the change
Added importing splunk/otel-web for the "set the user id on all spans" example

@jelkhouri-splunk
Update manual-rum-browser-instrumentation.rst
6cd8906 
Added importing splunk/otel-web for the "set the user id on all spans" example
@jelkhouri-splunk jelkhouri-splunk requested a review from a team as a code owner January 23, 2025 18:19
@jcatera-splunk jcatera-splunk added the stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise label Jan 23, 2025
jcatera-splunk
jcatera-splunk approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jcatera-splunk jcatera-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jelkhouri-splunk ! I had @pmurgai review and approve.

@jcatera-splunk
Update gdi/get-data-in/rum/browser/manual-rum-browser-instrumentation…
881154a 
….rst


The rST syntax is incorrect and breaking the test.
jcatera-splunk
jcatera-splunk approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jcatera-splunk jcatera-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to correct the rST syntax.

@jcatera-splunk jcatera-splunk merged commit c1450b5 into splunk:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcatera-splunk jcatera-splunk jcatera-splunk approved these changes

Assignees
No one assigned
Labels
external stop-alert Stops Slack notification in #o11y-docs-feedback so that PR can be worked wo unnecessary noise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelkhouri-splunk @jcatera-splunk @srv-rpa-o11y-docs-splunk