-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] GR13 V3 SignIn Logs logic with consideration of retention period and misc. error handling update #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutt0
changed the title
logic update with signinlogs
[Bugfix] GR13 V3 SignIn Logs logic with consideration of retention period
Dec 17, 2024
dutt0
changed the title
[Bugfix] GR13 V3 SignIn Logs logic with consideration of retention period
[Bugfix] GR13 V3 SignIn Logs logic with consideration of retention period and misc. error handling update
Dec 18, 2024
singhgss
approved these changes
Dec 18, 2024
alalvi00
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Updated the controls Break Glass Account Testing Cadence (M) which ensures that Break Glass accounts remain active and secure by monitoring the last login date.
This PR fixes/adds/changes/removes
This pull request
• Collects BG UPN from the config,json
• Validates BG accounts exist in config.json
• Validates BG accounts' sign-in activity/log enabled
• Retrieves last login dates for each UPN
• Compliant if the date is within the last year
• Non-compliant if otherwise
Breaking Changes
N/A
Testing Evidence
Tested with test tenant pipeline run.
As part of this Pull Request I have
main
branch