Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] GR1 V5 Compliance Messages and Code Logic Update #318

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

alalvi00
Copy link
Contributor

@alalvi00 alalvi00 commented Dec 18, 2024

Overview/Summary

This pull request addresses two bug-fix tickets for GR1V5. The following updates have been implemented:

  1. Enhanced Compliance Messaging
  • Updated the control logic to include more specific and actionable compliance messages.
  • These messages now clearly identify what corrective actions are required to achieve compliance.
  1. New Compliance Messages Added
  • Introduced new compliance messages to ensure clarity and alignment with the control's objectives.
  • These messages enhance usability by providing detailed guidance on addressing non-compliance issues.

This improvement aims to streamline the compliance process and reduce ambiguity for users managing GR1V5 controls.

This PR fixes/adds/changes/removes

  1. Check-AlertsMonitor (psm1 and psd1) files are updated
  2. GR-ComplianceChecks-Msgs (en and fr) files are updated
  3. Updated zip modules for respective files

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@alalvi00 alalvi00 merged commit 28c47b6 into main Dec 19, 2024
6 checks passed
@alalvi00 alalvi00 deleted the GR1V5-enhancement_aalvi branch December 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR1 | Validation 5 | Missing comment GR1 | Validation 5 | comment issues/ comment review required
3 participants