Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Remove Management Group Evaluation from GR5 Controls #385

Merged
merged 3 commits into from
Jan 31, 2025
Merged

[Enhancement] Remove Management Group Evaluation from GR5 Controls #385

merged 3 commits into from
Jan 31, 2025
+2 −27

Conversation

alalvi00
Copy link
Contributor

@alalvi00 alalvi00 commented Jan 31, 2025 •
edited
Loading

Overview/Summary

Removes management groups from the AllowedLocation control and only parses susbcriptions

Closes #375

This PR fixes/adds/changes/removes

  1. Check-AllowedLocationPolicy.psm1 updated
  2. Check-AllowedLocationPolicy.psd1 updated

Breaking Changes

N/A

Testing Evidence

Updated control now only parses subscriptions:

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@alalvi00 alalvi00 merged commit d0c3f68 into main Jan 31, 2025
4 checks passed
@alalvi00 alalvi00 deleted the gr5-removeMGgroups_aalvi branch January 31, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutt0 dutt0 dutt0 approved these changes

@singhgss singhgss singhgss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Management Group Evaluation from GR5 Controls
3 participants
@alalvi00 @singhgss @dutt0