Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/wait for seedphrase input #17043

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Test/wait for seedphrase input #17043

wants to merge 9 commits into from
+6,614 −512

Conversation

glitchminer
Copy link
Contributor

What does the PR do

Fixes timeout when waiting on seedphrase input screen during recovery phrase import test.

Affected areas

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

caybro and others added 9 commits January 7, 2025 17:16
@caybro
feat(Onboarding): Create Profile & Login flows
6e4d3ff 
- implement the basic Onboarding UI skeleton and the Create Profile
flows
- adjust the PasswordView and EnterSeedPhrase views to the latest design
- add the main OnboardingLayout and StatusPinInput pages to Storybook
- change terminology app-wide: "Seed phrase" -> "Recovery phrase"
- implement the Login flows (seed, sync, keycard)
- amend the keycard flow sequences with separate (non) empty page

Fixes #16719
Fixes #16742
Fixes #16743
@micieslak @caybro
Storybook: OnboardingLayout page - add seed phrase verification auto-…
f067b44 
…fill
@micieslak @caybro
feat(OnboardingLayout): Decompose into smaller, pure ui sub-flows
09a5ea6 
Closes: #16947
@caybro
fix(OnboardingFlow): collect enableBiometrics and seedphrase data
630d760 
- extend the  tests to verify whether we collected the correct data
- restore the "pointing hand" cursor on clickable elements
- some minor improvements
@caybro
feat(LoginWithKeycardFlow): implement "Unlock with recovery phrase"
4b534d3 
- instead of the factory reset when the keycard is locked
@caybro
chore(StatusPasswordStrengthIndicator): remove defaults from docu
baa9cc8 
- they are not very useful (and were outdated anyway)
@micieslak @caybro
Onboarding: non-intrusive current page name inspection
5069c11
@caybro
fix(Onboarding): enable the network checks by default
5a6613a
@glitchminer
test_: increase wait for seedphrase input
2dca0f4
@glitchminer glitchminer changed the base branch from master to feat/onboarding-rework-1 January 9, 2025 13:57
@status-im-auto
Copy link
Member

status-im-auto commented Jan 9, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2dca0f4 #2 2025-01-09 14:06:45 ~8 min macos/aarch64 🍎dmg
✔️ 2dca0f4 #2 2025-01-09 14:06:51 ~8 min tests/nim 📄log
✔️ 2dca0f4 #2 2025-01-09 14:10:36 ~12 min tests/ui 📄log
✔️ 2dca0f4 #2 2025-01-09 14:14:53 ~16 min linux-nix/x86_64 📦tgz
✔️ 2dca0f4 #2 2025-01-09 14:16:27 ~18 min macos/x86_64 🍎dmg
✔️ 2dca0f4 #2 2025-01-09 14:18:29 ~20 min linux/x86_64 📦tgz
✔️ 2dca0f4 #2 2025-01-09 14:21:35 ~23 min windows/x86_64 💿exe
✔️ 2dca0f4 #3 2025-01-14 09:58:13 ~8 min tests/nim 📄log
✔️ 2dca0f4 #3 2025-01-14 09:58:58 ~8 min macos/aarch64 🍎dmg
✔️ 2dca0f4 #3 2025-01-14 10:02:49 ~12 min macos/x86_64 🍎dmg
✔️ 2dca0f4 #3 2025-01-14 10:03:07 ~13 min tests/ui 📄log
✔️ 2dca0f4 #3 2025-01-14 10:07:44 ~17 min linux-nix/x86_64 📦tgz
✔️ 2dca0f4 #3 2025-01-14 10:12:57 ~22 min linux/x86_64 📦tgz
✔️ 2dca0f4 #3 2025-01-14 10:15:08 ~25 min windows/x86_64 💿exe

@micieslak micieslak force-pushed the feat/onboarding-rework-1 branch 2 times, most recently from d5524fd to 35b8620 Compare January 13, 2025 11:27
Base automatically changed from feat/onboarding-rework-1 to master January 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micieslak micieslak Awaiting requested review from micieslak micieslak will be requested when the pull request is marked ready for review micieslak is a code owner

@caybro caybro Awaiting requested review from caybro caybro will be requested when the pull request is marked ready for review caybro is a code owner

@alexjba alexjba Awaiting requested review from alexjba alexjba will be requested when the pull request is marked ready for review alexjba is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glitchminer @status-im-auto @caybro @micieslak