feat(@desktop/wallet): Write Unit tests for SimpleSendModal, SimpleTransactionFees and SendModalFooter #17145
+1,401
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
dlipicar
and removed request for
a team
Jenkins BuildsClick to see older builds (7)
|
caybro
approved these changes
Jan 29, 2025
| compare(controlUnderTest.color, Theme.palette.baseColor3) | ||
| verify(controlUnderTest.dropShadowEnabled) | ||
|
|
||
| compare(estTimeLabel.text, qsTr("Est time")) |
There was a problem hiding this comment.
No need to use qsTr() in tests at all; they always run in English :)
…ansactionFees and SendModalFooter fixes #17123
Khushboo-dev-cpp
force-pushed
the
feat/17123
branch
from
9979bc5 to
3e99d1e
Compare
Khushboo-dev-cpp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17123y
What does the PR do
Writing Unit Tests for -
Affected areas
SimpleSendModal
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)