Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@desktop/wallet): Add option to not show Popular section in TokenSelectorViewAdaptor.qml #17179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Khushboo-dev-cpp
Copy link
Contributor

fixes #17148

What does the PR do

Implements the logic to show default token (ETH, DAI and SNT) with 0 balance in SendModal

Affected areas

SimpleSend

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Screen.Recording.2025-01-31.at.12.52.12.mov

@Khushboo-dev-cpp Khushboo-dev-cpp requested review from saledjenic and removed request for a team January 31, 2025 11:53
@status-im-auto
Copy link
Member

status-im-auto commented Jan 31, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 699cc16 #2 2025-01-31 12:11:15 ~9 min tests/nim 📄log
699cc16 #2 2025-01-31 12:14:46 ~12 min tests/ui 📄log
✔️ 699cc16 #2 2025-01-31 12:17:12 ~15 min macos/x86_64 🍎dmg
✔️ 699cc16 #2 2025-01-31 12:23:19 ~21 min linux/x86_64 📦tgz
✔️ 699cc16 #2 2025-01-31 12:26:27 ~24 min linux-nix/x86_64 📦tgz
✔️ 699cc16 #2 2025-01-31 12:30:52 ~29 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to not show Popular section in TokenSelectorViewAdaptor.qml
3 participants