Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car Port: Genesis GV70 2.5T 2025 korea (HDA1) #49

Open
wants to merge 1 commit into
base: master-new
Choose a base branch
from

Conversation

chanhojung
Copy link

@chanhojung chanhojung commented Jan 12, 2025

Summary by Sourcery

New Features:

  • Support for Genesis GV70 2.5T 2025 Korea has been added.

Copy link

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This pull request adds support for the 2025 Genesis GV70 2.5T (Korea) HDA1.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added fingerprint for the 2025 Genesis GV70 2.5T (Korea) HDA1.
  • Added fingerprint JK MFC AT KOR LHD 1.00 1.00 99211-AR500 240311 to the Ecu.abs section.
  • Added fingerprint JK__ RDR ----- 1.00 1.01 99110-AR500 to the Ecu.fwdRadar section.
opendbc/car/hyundai/fingerprints.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chanhojung - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant