Deprecated fix #17
Open
Deprecated fix #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- up php to 8+ - up phpuntit to 9+ - up phpcov to 8+
|
Убрал все ненужные phpdoc типы, поднял php до 8 версии, проверил все тесты. Так же по ходу поправил пару багов, буквально косметику. |
|
Thanks, hope your PR will be accepted soon. I tried to upgrade my project to use PHP 8.1 but reached an issue with the return type being incorrect with ArrayAccess class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Привёл объявление методов к новому синтаксису, а то deprecated ругается в тинкере.
Только начал юзать пакет, возможно где-то ещё есть подобные задачи, предлагаю оставить pr пока как есть, дополню со временем, если ещё где найду.