Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading types with autoloading #660

Closed
wants to merge 3 commits into from

Conversation

oprypkhantc
Copy link
Contributor

Closes #659

The $autoload flag is true by default, as I feel that's sensible. But to avoid another breaking change I can change it to false.

Otherwise it's a simple fix. $autoload = true means a class would simply be autoloaded with class_exists() and that's it, same as ->addControllerNamespace(). $autoload = false means the "legacy" behaviour

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (53f9d49) to head (255b287).
Report is 70 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #660      +/-   ##
============================================
- Coverage     95.72%   95.30%   -0.43%     
- Complexity     1773     1820      +47     
============================================
  Files           154      171      +17     
  Lines          4586     4854     +268     
============================================
+ Hits           4390     4626     +236     
- Misses          196      228      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oprypkhantc oprypkhantc deleted the autoload branch March 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQLite attempts to load non-class files, resulting in weird errors
2 participants