Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translations Improvements #382

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

Nanush7
Copy link
Member

@Nanush7 Nanush7 commented Mar 27, 2024

No description provided.

@Nanush7 Nanush7 requested a review from dmint789 March 27, 2024 01:49
@Nanush7 Nanush7 requested a review from a team as a code owner March 27, 2024 01:49
Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion. Also, I have a couple more suggestions:

  1. We should add a point about the judge having to check the timer is in 2 pad mode
  2. We should mention that the reset button must be held down on gen 5 timers or newer (to future proof it)

edudoc/judge-tutorial/judge-tutorial.md Outdated Show resolved Hide resolved
@Nanush7 Nanush7 requested a review from dmint789 April 4, 2024 15:10
@Nanush7
Copy link
Member Author

Nanush7 commented Apr 21, 2024

@dmint789 Looks good?

@dmint789
Copy link
Member

@Nanush7 yeah, lgtm, I'll approve. Did you update the Spanish version accordingly? Does the current Spanish translation match the English version? Also, as a general thought, do you not think we're replicating the regulations a bit too much in this document now? It might require more maintenance that way. But if you think this is kind of necessary for a doc like this, we can leave it.

Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I just realized, the version hasn't been updated. Can you change it to 2.1 in both the English and the Spanish version?

@Nanush7
Copy link
Member Author

Nanush7 commented Apr 23, 2024

@dmint789 Done! :)

Also, as a general thought, do you not think we're replicating the regulations a bit too much in this document now?

It's important to not give just half of the information, as it may lead to confusion. I agree we should keep it as simple as possible, but I don't think the current version replicates the regulations that much.

@Nanush7 Nanush7 requested a review from dmint789 April 23, 2024 15:00
@dmint789
Copy link
Member

@Nanush7 LGTM. Can you remind me, do you have the rights to merge? If not, I'll squash merge this for you.

@Nanush7 Nanush7 merged commit 73e9f39 into thewca:master Apr 23, 2024
1 check passed
@Nanush7 Nanush7 deleted the judge-tutorial-spanish-fixes branch April 23, 2024 15:12
@Nanush7
Copy link
Member Author

Nanush7 commented Apr 23, 2024

I didn't know we had the right to merge, but looks like we do. :p

@dmint789
Copy link
Member

Yeah, I requested the rights last year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants