-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish Translations Improvements #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion. Also, I have a couple more suggestions:
- We should add a point about the judge having to check the timer is in 2 pad mode
- We should mention that the reset button must be held down on gen 5 timers or newer (to future proof it)
@dmint789 Looks good? |
@Nanush7 yeah, lgtm, I'll approve. Did you update the Spanish version accordingly? Does the current Spanish translation match the English version? Also, as a general thought, do you not think we're replicating the regulations a bit too much in this document now? It might require more maintenance that way. But if you think this is kind of necessary for a doc like this, we can leave it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I just realized, the version hasn't been updated. Can you change it to 2.1 in both the English and the Spanish version?
@dmint789 Done! :)
It's important to not give just half of the information, as it may lead to confusion. I agree we should keep it as simple as possible, but I don't think the current version replicates the regulations that much. |
@Nanush7 LGTM. Can you remind me, do you have the rights to merge? If not, I'll squash merge this for you. |
I didn't know we had the right to merge, but looks like we do. :p |
Yeah, I requested the rights last year |
No description provided.